fix: 在 handler 中检查错误，不再静默丢弃

handlers/review.go

@@ -90,7 +90,10 @@ func (h *ReviewHandler) Review(c *gin.Context) {
 	}
 
 	sendEvent := func(event string, data interface{}) {
-		jsonData, _ := json.Marshal(data)
+		jsonData, err := json.Marshal(data)
+		if err != nil {
+			jsonData = []byte(`{"error":"failed to marshal event data"}`)
+		}
 		fmt.Fprintf(c.Writer, "event: %s\ndata: %s\n\n", event, jsonData)
 		flusher.Flush()
 	}
@@ -106,15 +109,25 @@ func (h *ReviewHandler) Review(c *gin.Context) {
 	}
 
 	// Save analysis to DB with full review result
-	resultJSON, _ := json.Marshal(reviewResult)
+	resultJSON, err := json.Marshal(reviewResult)
+	if err != nil {
+		sendEvent("error", map[string]interface{}{"message": "marshal result: " + err.Error()})
+		return
+	}
 	res, err := h.db.Exec(`INSERT INTO analyses (repo_id, type, base_ref, head_ref, result) VALUES (?, 'code_review', ?, ?, ?)`,
 		id, req.Base, req.Head, string(resultJSON))
-	if err == nil {
-		analysisID, _ := res.LastInsertId()
-		sendEvent("analysis_saved", map[string]interface{}{
-			"analysis_id": analysisID,
-		})
+	if err != nil {
+		sendEvent("error", map[string]interface{}{"message": "save analysis: " + err.Error()})
+		return
 	}
+	analysisID, err := res.LastInsertId()
+	if err != nil {
+		sendEvent("error", map[string]interface{}{"message": "get analysis id: " + err.Error()})
+		return
+	}
+	sendEvent("analysis_saved", map[string]interface{}{
+		"analysis_id": analysisID,
+	})
 }
 
 // SaveNotes handles POST /api/repos/:id/review/notes — upsert a review note.
@@ -202,6 +215,10 @@ func (h *ReviewHandler) ListReviews(c *gin.Context) {
 			"created_at": createdAt,
 		})
 	}
+	if err := rows.Err(); err != nil {
+		c.JSON(http.StatusInternalServerError, gin.H{"error": err.Error()})
+		return
+	}
 
 	if analyses == nil {
 		analyses = []map[string]interface{}{}
@@ -305,7 +322,11 @@ func (h *ReviewHandler) GeneratePDF(c *gin.Context) {
 	}
 
 	// Return PDF as download
-	filename := fmt.Sprintf("pr-helper-review-%s.pdf", createdAt[:10])
+	dateStr := createdAt
+	if len(dateStr) > 10 {
+		dateStr = dateStr[:10]
+	}
+	filename := fmt.Sprintf("pr-helper-review-%s.pdf", dateStr)
 	c.Header("Content-Type", "application/pdf")
 	c.Header("Content-Disposition", fmt.Sprintf("attachment; filename=%s", filename))
 	c.Data(http.StatusOK, "application/pdf", pdfBytes)